-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-cli): move progressbar into ink #14220
feat(gatsby-cli): move progressbar into ink #14220
Conversation
d043896
to
4f28fba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! What will happen if you use an older gatsby-plugin-sharp or gatsby-source-filesystem with this version of the cli?
I wonder if this PR should be published under tags so we can do some manual testing with CI, different node versions and different plugin versions?
I think the design of the progress bars feels a bit busy with progress bar, item counter, elapsed time and percentage. But I realise it's like that already :) let's not worry about it for now, we can always revisit in a later PR.
@wardpeet can you post a gif of how this looks now? |
it looks like ink has some issues repainting on windows, unsure how it behaves on mac/linux. |
7fcd316
to
1ecca8f
Compare
@ward This looks good! Did you find any more info about the Windows repainting issue? |
I think it's an issue with ink and nothing we can do about. It mostly happens when to activities are running. |
@wardpeet Shall we open an issue in ink for this? Is this a blocker or can we merge this in for now? |
it's not a blocker, i'll write an upstream issue. It's still better what we have now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @wardpeet 🥇
Published in |
Description
Moving progressbar into reporter so it's part of the reporter and not a seperate package. A seperate package like we have now doesn't play well with ink-cli. This will also make the move easier to structured logging and a json formatter.
Related Issues
#11076