chore(gatsby-dev-cli): wrap ignore pattern in quotes (build scripts) #14465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty confusing issue - before this change, something replaces ignore pattern with something else:
See
src/__tests__
instead of**/__tests
. In some cases this would cause broken releases - i.e. https://unpkg.com/gatsby-dev-cli@2.4.16/dist/watch.js - watch file is not the code there it's compiled tests (wat).wrapping pattern in quotes (or using
--ignore=pattern
) fixes this:so let's go with that
More things that are confusing - this seems to happen only with
gatsby-dev-cli
- most of our packages use same build script but it doesn't happen there 🤷♂