Refactor gatsby-plugin-google-analytics gatsby-browser.js #14572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gatsby-browser.js file in gatsby-plugin-google-analytics and gatsby-plugin-google-gtag have borderline identical functionality howeve that is slightly obscured as their implementation is slightly different, notably gatsby-plugin-google-analytics does not use the early return pattern which means the nesting of everything is different if you try and diff the two files. This commit makes gatsby-plugin-google-analytics use the early return pattern to make it applying the same changes to this an gatsby-plugin-google-gtag easier.
BPScott
force-pushed
the
standardize-analytics
branch
from
d315722
to
22ee1b8
Compare
freiksenet
approved these changes
Jun 10, 2019
|
Thank you! |
mxxk
pushed a commit
to mxxk/gatsby
that referenced
this pull request
Jun 21, 2019
…alytics gatsby-browser.js (gatsbyjs#14572) The gatsby-browser.js file in gatsby-plugin-google-analytics and gatsby-plugin-google-gtag have borderline identical functionality howeve that is slightly obscured as their implementation is slightly different, notably gatsby-plugin-google-analytics does not use the early return pattern which means the nesting of everything is different if you try and diff the two files. This commit makes gatsby-plugin-google-analytics use the early return pattern to make it applying the same changes to this an gatsby-plugin-google-gtag easier.
johno
pushed a commit
to johno/gatsby
that referenced
this pull request
Jul 17, 2019
…alytics gatsby-browser.js (gatsbyjs#14572) The gatsby-browser.js file in gatsby-plugin-google-analytics and gatsby-plugin-google-gtag have borderline identical functionality howeve that is slightly obscured as their implementation is slightly different, notably gatsby-plugin-google-analytics does not use the early return pattern which means the nesting of everything is different if you try and diff the two files. This commit makes gatsby-plugin-google-analytics use the early return pattern to make it applying the same changes to this an gatsby-plugin-google-gtag easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The gatsby-browser.js file in gatsby-plugin-google-analytics and
gatsby-plugin-google-gtag have borderline identical functionality howeve
that is slightly obscured as their implementation is slightly different,
notably gatsby-plugin-google-analytics does not use the early return
pattern which means the nesting of everything is different if you try
and diff the two files.
This commit makes gatsby-plugin-google-analytics use the early return
pattern to make it applying the same changes to this an
gatsby-plugin-google-gtag easier.
Run
diff -u packages/gatsby-plugin-google-analytics/src/gatsby-browser.js packages/gatsby-plugin-google-gtag/src/gatsby-browser.jsto see that the contents is now nearly identical