-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add REPL documentation to the Gatsby Docs #15309
Conversation
Thanks for the work so far @n8finch! Just a thing to do is since you are fleshing out this stub, I would recommend removing the asterisk for the |
@lannonbr thanks for the heads up, I'd completely missed that! 👍 |
Hmm, I'm showing some CircleCI tests failing... When I look at the details, I'm not sure what went wrong. Do I need to run |
So there's 502 bad gateway errors coming up. Cloudflare is having some outages today and NPM is affected by such, so it's no issue on your end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you mentioned this is still a WIP PR but I think it's looking great! I'd never used the REPL before this but I think you give good examples.
I made a couple little suggestions, really appreciate your work on this @n8finch!
Hey @gillkyle, thanks for the review and the corrections! I've never been the best speller 😂. I've pushed up a new commit now with those changes. I've also removed the WIP and added more documentation here. It looks like there might be some tests failing, which I'm not sure how to resolve. Any pointers? Thanks again! |
Awesome! Thanks @n8finch! Those additional updates look awesome 😄 As far as tests go, it looks like CircleCI is complaining about linting, I think the command from this doc might be enough:
and then push the changes. Seems like the offending file is I've seen the windows tests just kind of fail for no real obvious reason, so pushing some change might just be enough for them to run again and maybe work. Might have to look into those more if they keep failing. |
@gillkyle Woohoo! That worked... Hahaha.. Machines... Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @n8finch! Appreciate you iterating on this several times to get everything really solid 😄
Description
Currently [WIP], this PR creates documentation for the Gatsby CLI REPL shell. This was merged in #7262, but didn't include documentation.
I've labeled this [WIP] because I'd like feedback on the format and content of the documentation:
I just want to make sure 🤓.
Once I get feedback, I'll finish up the docs for a merge.
Also, it looks like the
dataPaths
command is throwing an error? But I'll double check on that and file a bug issue (and hopefully a PR to fix it!) after the docs.Related Issues
Fixes #7484