Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-plugin-netlify-cms): add deprecation message for netlify-cms #15588

Merged
merged 1 commit into from
Jul 10, 2019
Merged

feat(gatsby-plugin-netlify-cms): add deprecation message for netlify-cms #15588

merged 1 commit into from
Jul 10, 2019

Conversation

wardpeet
Copy link
Contributor

Description

netlify-cms-app is the successor of netlify-cms as it uses es6 modules instead of umd. Netlify-cms-app is a peer-dependency of gatsby-plugin-netlify-cms whereas netlify-cms isn't anymore.

Message looks like this:

warn The netlify-cms package is deprecated, please install netlify-cms-app instead. You can do this by running "npm install netlify-cms-app"

Related Issues

#15256 (comment)

@wardpeet wardpeet requested a review from a team as a code owner July 10, 2019 07:36
@wardpeet wardpeet mentioned this pull request Jul 10, 2019
Closed
sidharthachatterjee
sidharthachatterjee approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@sidharthachatterjee sidharthachatterjee merged commit 7932414 into gatsbyjs:master Jul 10, 2019
@wardpeet wardpeet deleted the feat/deprecation-netlify-cms branch July 10, 2019 11:04
johno pushed a commit to johno/gatsby that referenced this pull request Jul 17, 2019
@wardpeet @johno
feat(gatsby-plugin-netlify-cms): add deprecation message for netlify-…
0d923ec 
…cms (gatsbyjs#15588)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wardpeet @sidharthachatterjee