Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: expand deploy recipe #15605

Merged
merged 19 commits into from
Jul 20, 2019
Merged

Docs: expand deploy recipe #15605

merged 19 commits into from
Jul 20, 2019

Conversation

tom-raley
Copy link
Contributor

Description

Expands the Deploy section in recipes and updates it to the new format

Related Issues

Addresses #15319

@tom-raley tom-raley requested a review from a team July 10, 2019 16:36
@tom-raley tom-raley requested a review from a team as a code owner July 15, 2019 20:44
marcysutton
marcysutton suggested changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for working on this! I think it's going to be a great addition. I left some suggestions to make it a bit shorter, let me know if you have any questions!

docs/docs/recipes.md Outdated Show resolved Hide resolved
docs/docs/recipes.md Outdated Show resolved Hide resolved
docs/docs/recipes.md Outdated Show resolved Hide resolved
docs/docs/recipes.md Outdated Show resolved Hide resolved
docs/docs/recipes.md Outdated Show resolved Hide resolved
docs/docs/recipes.md Outdated Show resolved Hide resolved
docs/docs/recipes.md Outdated Show resolved Hide resolved
docs/docs/recipes.md Outdated Show resolved Hide resolved
docs/docs/recipes.md Outdated Show resolved Hide resolved
docs/docs/recipes.md Show resolved Hide resolved
tom-raley and others added 10 commits July 15, 2019 16:45
@tom-raley
Shorten prerequisites in docs/docs/recipes.md
9c09bdf 
Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
@tom-raley
Clean up path prefix steps docs/docs/recipes.md
2ea9763 
Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
@tom-raley
Clean up step #3 in docs/docs/recipes.md
7826a58 
Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
@tom-raley
Clean up #4 in docs/docs/recipes.md
540cd27 
Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
@tom-raley
Clean up #5 in docs/docs/recipes.md
0c22475 
Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
@tom-raley
Shorten build/serve command in deploy recipe docs/docs/recipes.md
d5a806f 
Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
@tom-raley
Update docs/docs/recipes.md
7f06b04 
Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
@tom-raley
Shorten path prefix deploy recipe section docs/docs/recipes.md
3939343 
Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
@tom-raley
Remove actual deployment from deploy recipe docs/docs/recipes.md
8849e40 
Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
@tom-raley
Clean up prefix-paths section deploy recipe docs/docs/recipes.md
d17615f 
Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
@tom-raley
Copy link
Contributor Author

Thanks for the feedback! I tend to err on the side of being more verbose rather than less, which is the whole point of a recipe, so all the feedback is much appreciated!

@tom-raley tom-raley requested a review from marcysutton July 15, 2019 21:52
marcysutton
marcysutton suggested changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates! I made a couple of small suggestions–it's really close. Thanks again!

docs/docs/recipes.md Show resolved Hide resolved
docs/docs/recipes.md Outdated Show resolved Hide resolved
docs/docs/recipes.md Outdated Show resolved Hide resolved
tom-raley and others added 3 commits July 19, 2019 09:29
@tom-raley
Update deploy recipe formatting
3c5c12a 
Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
@tom-raley
Update formatting on deploy recipe CLI bullet point
660251e 
Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
@tom-raley
Added deploy recipe header
a113d8c 
Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
@tom-raley tom-raley requested a review from marcysutton July 19, 2019 14:32
marcysutton
marcysutton previously approved these changes Jul 20, 2019
View reviewed changes
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot! Thanks for your work on this, @tom-raley! 🌮

@marcysutton marcysutton added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jul 20, 2019
@gatsbybot gatsbybot merged commit 96aa890 into gatsbyjs:master Jul 20, 2019
@marcysutton marcysutton mentioned this pull request Jul 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcysutton marcysutton marcysutton approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tom-raley @marcysutton @gatsbybot