fix(gatsby-plugin-google-analytics): Fix broken script #16223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…15280) gatsbyjs@b3ed9be had a syntax error where, after transpiling the javascript, users are given a syntax error. There was an if-statement which ends up not being closed. This commit fixes that.
karlsander
approved these changes
Jul 30, 2019
|
Oops my code review was kind of pointless since I'm not a code owner. I don't know how much this code can be improved with formatting. Looks pretty good already for being a huge string interpolation. I think it could be improved with some refactoring. Pulling out all the processing of options so that the string interpolation only contains boolean and string variables defined right before it might be a good first step? |
sidharthachatterjee
approved these changes
Jul 30, 2019
sidharthachatterjee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a syntax error in gatsby-plugin-google-analytics
where an if-statement was not closed in transpiled code.
Description
#15280 introduced a post-transpilation syntax error. 😢
There was an if-statement which ends up not being closed.
This PR fixes that.
Related Issues
PS: I would love some advice on possible indentation improvements using our linter or tests. 😄 I gave some things a shot but nothing looked quite right.