fix(gatsby-plugin-feed): respect custom options and require title in config #16814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyalroth
force-pushed
the
gatsby-plugin-feed/bug/16177/ignore-custom-options
branch
from
f03c619
to
02bac52
Compare
lannonbr
changed the title
| @@ -4,7 +4,7 @@ import Joi from "@hapi/joi" | |||
| const feed = Joi.object({ | |||
| output: Joi.string().required(), | |||
| query: Joi.string().required(), | |||
| title: Joi.string(), | |||
| title: Joi.string().required(), | |||
There was a problem hiding this comment.
Documentation says that "Each feed must include output, query, and title." so this is good
sidharthachatterjee
added
the
status: awaiting author response
| }, | ||
| generator, | ||
| ...rest |
There was a problem hiding this comment.
So it looks like this does indeed fix the issue! Took a while for us to catch it so we need it now!
…equire title configuration
eyalroth
force-pushed
the
gatsby-plugin-feed/bug/16177/ignore-custom-options
branch
from
02bac52
to
8738120
Compare
sidharthachatterjee
removed
the
status: awaiting author response
sidharthachatterjee
approved these changes
Aug 23, 2019
There was a problem hiding this comment.
Looks good! Thank you so much for your work on this @eyalroth 👍
sidharthachatterjee
changed the title
|
Holy buckets, @eyalroth — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
|
Published in |
eyalroth
added a commit
to eyalroth/gatsby
that referenced
this pull request
Aug 27, 2019
gatsbyjs#16814 and replacing it with a warning
eyalroth
added a commit
to eyalroth/gatsby
that referenced
this pull request
Aug 27, 2019
gatsbyjs#16814 and replacing it with a warning
eyalroth
added a commit
to eyalroth/gatsby
that referenced
this pull request
Aug 28, 2019
gatsbyjs#16814 and replacing it with a warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15595.
Fixes #16177.
Note that the plugin will now require a title to be configured for each feed, as per the documentation.