Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-image): Fix loading="eager" & critical #17148

Merged
merged 3 commits into from
Aug 29, 2019

Conversation

glennreyes
Copy link
Contributor

@glennreyes glennreyes commented Aug 28, 2019

Description

This is a follow up fix of #16746. Basically there where some checks missing which caused #17007 and eventually #17017 (cc @dkthehuman).

Related Issues

Fixes #17007
Related #17017 (Eventually fixes, waiting for a confirmation of @dkthehuman).
Related #14972

@glennreyes glennreyes requested a review from a team as a code owner August 28, 2019 16:35
@herecydev
Copy link
Contributor

I think #17120 is not the right linking issue?

@glennreyes
Copy link
Contributor Author

Thanks @herecydev, updated.

@wardpeet
Copy link
Contributor

This is awesome! creating a variable that holds that property is much cleaner and easier to read. Thank you for fixing this one. I'm giving it a spin and merge afterwards! 🎉 💯

@lannonbr lannonbr added the topic: media Related to gatsby-plugin-image, or general image/media processing topics label Aug 29, 2019
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm! I love it when a problem gets fixed and the resulting code looks cleaner than before! 🥇

@wardpeet wardpeet merged commit 43536e0 into gatsbyjs:master Aug 29, 2019
@gatsbot
Copy link

gatsbot bot commented Aug 29, 2019

Holy buckets, @glennreyes — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@glennreyes glennreyes deleted the fix-eager branch August 29, 2019 21:33
@wardpeet
Copy link
Contributor

Published in gatsby-image@2.2.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gatsby-image] Placeholder doesn't disappear/unblur on initial page load
4 participants