-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby-image): Fix loading="eager" & critical #17148
Conversation
I think #17120 is not the right linking issue? |
Thanks @herecydev, updated. |
This is awesome! creating a variable that holds that property is much cleaner and easier to read. Thank you for fixing this one. I'm giving it a spin and merge afterwards! 🎉 💯 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works like a charm! I love it when a problem gets fixed and the resulting code looks cleaner than before! 🥇
Holy buckets, @glennreyes — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Published in |
Description
This is a follow up fix of #16746. Basically there where some checks missing which caused #17007 and eventually #17017 (cc @dkthehuman).
Related Issues
Fixes #17007
Related #17017 (Eventually fixes, waiting for a confirmation of @dkthehuman).
Related #14972