Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] [workflows] Gatsby v2 with Wordpress #17317

Closed
wants to merge 1 commit into from
Closed

[docs] [workflows] Gatsby v2 with Wordpress #17317

wants to merge 1 commit into from

Conversation

louiechristie
Copy link

Description

Incremental update to documentation for using Gatsby v2 sourcing from Wordpress.

Related Issues

Workaround to:
#6670

Relates to:
#13708 [good first issue]

Incremental update to:
#13876

Incremental update to documentation for using Gatsby v2 sourcing from Wordpress. [good first issue]

Workaround to:
#6670

Relates to:
#13708 [good first issue]

Incremental update to:
#13876
@@ -9,6 +9,8 @@ WordPress is a free and open-source content management system (CMS). Let's say y
_Note: this guide uses the `gatsby-starter-default` to provide you with the knowledge necessary to start working with WordPress but if you get stuck at some point of the guide feel free to use
[this example](https://github.com/gatsbyjs/gatsby/tree/master/examples/using-wordpress) to gain extra insights._

_Note: If you are using Gastby v2 then use [`gatsby-starter-wordpress`](https://github.com/GatsbyCentral/gatsby-starter-wordpress) instead, follow the instructions [here](https://github.com/GatsbyCentral/gatsby-starter-wordpress)._
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would linking to this be needed? Our /examples/using-wordpress should also work with Gatsby v2.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally think it would be better to update the example hosted in the Gatsby repo than to link elsewhere. What about that example on GatsbyCentral is necessary? Everything we recommend should be usable with Gatsby v2 at this point.

@LekoArts LekoArts added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Sep 4, 2019
@marcysutton
Copy link
Contributor

Hey! Thanks so much for opening a pull request!

We really appreciate you sending this over, but the change you’ve proposed is not going to be accepted because it doesn't meaningfully improve docs, fix a bug, or otherwise improve functionality.

We absolutely want to have you as a contributor, so please take a look at [our open issues][open-issues] for ideas, and please reach out to us on Twitter at @gatsbyjs with questions.

We offer pair programming sessions if you’d like to work with one of our maintainers to make another contribution. https://gatsby.dev/pairing

Thanks again, and we look forward to seeing more PRs from you in the future! 💪💜
[open-issues]: https://github.com/gatsbyjs/gatsby/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants