chore(docs): clarify local setup instructions #18406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francocorreasosa
suggested changes
Oct 9, 2019
LekoArts
changed the title
LekoArts
added
the
bot: merge on green
pieh
previously requested changes
Oct 14, 2019
LekoArts
added
type: documentation
|
Good point! Feel free to add that note in the current sentence then 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clarify a few instructions that I found confusing during local setup for docs site:
.env.developmentfile for docs siteOn a related note, even after adding the environment variable in
.env.develpmentfile the build process still took time to generate thumbnails. I followed the instructions as mentioned here.Since this looked like a small enough change I considered opening a PR directly. Please let me know if anything else helps. Thanks!