Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): Fix filtering on resolvable children #19586

Merged
merged 1 commit into from
Nov 18, 2019

Conversation

freiksenet
Copy link
Contributor

Fixes #19357

@freiksenet freiksenet requested a review from a team as a code owner November 18, 2019 10:50
@vladar
Copy link
Contributor

vladar commented Nov 18, 2019

LGTM. And now I know what this determineSearchableFields method is responsible for

@freiksenet freiksenet added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Nov 18, 2019
@freiksenet freiksenet changed the title Fix filtering on resolvable children fix(gatsby): Fix filtering on resolvable children Nov 18, 2019
@freiksenet freiksenet merged commit 7b500f4 into master Nov 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-filtering-on-children branch November 18, 2019 12:02
await determineSearchableFields({
schemaComposer,
typeComposer,
parentSpan,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parentSpan is not used in function call?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't filter on childMdx fields
3 participants