Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): Respect @dontInfer directive on SitePage type #20662

Merged
merged 1 commit into from
Jan 17, 2020
Merged

fix(gatsby): Respect @dontInfer directive on SitePage type #20662

merged 1 commit into from
Jan 17, 2020

Conversation

vladar
Copy link
Contributor

@vladar vladar commented Jan 17, 2020

Description

Looks like PR #19781 broke the ability to disable type inference on SitePage. So the following adjustment didn't work anymore:

// gatsby-node.js
exports.createSchemaCustomization = ({ actions }) => {
  actions.createTypes(`
    type SitePage implements Node @dontInfer {
      path: String!
    }
  `)
}

This PR fixes it. So it should be working as advertised again.

Documentation

Scaling Issues (was not working before this fix, works after)

Related Issues

Fixes #20395

@vladar vladar requested a review from a team as a code owner January 17, 2020 08:46
@vladar vladar mentioned this pull request Jan 17, 2020
Closed
pvdz
pvdz approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :D

@vladar vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 17, 2020
@gatsbybot gatsbybot merged commit 631ba49 into master Jan 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the vladar/gh-20395 branch January 17, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvdz pvdz pvdz approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"update schema" step really slow after upgrading from 2.17 to 2.18
3 participants
@vladar @pvdz @gatsbybot