Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(www): import design tokens from gatsby-design-tokens in modal.js #21377

Merged
merged 1 commit into from
Feb 11, 2020
Merged

fix(www): import design tokens from gatsby-design-tokens in modal.js #21377

merged 1 commit into from
Feb 11, 2020

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Feb 11, 2020

Seems like this was missing in #21276

@pieh pieh requested a review from a team as a code owner February 11, 2020 19:19
blainekasten
blainekasten approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea if this is right, but I trust you 😄

@fk
Copy link
Contributor

fk commented Feb 11, 2020

Ugh crap. Thanks Michal! 🤗

fk
fk approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@fk fk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@pieh
Copy link
Contributor Author

pieh commented Feb 11, 2020

I think modal.js was recently factored out in #21330 and there was desync between that PR and the one with gatsby-design-tokens changes.

@pieh pieh merged commit d2fa8f7 into master Feb 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-showcase branch February 11, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blainekasten blainekasten blainekasten approved these changes

@fk fk fk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pieh @fk @blainekasten