Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): Convert normalize-page-path to typescript #22188

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

martijnjanssen
Copy link
Contributor

@martijnjanssen martijnjanssen commented Mar 11, 2020

Description

This PR converts the gatsby/src/util/normalize-page-path to typescript and adds a comment that this version is a typescript conversion of the original js version in gatsby/cache-dir/normalize-page-path.

This also extracts the reverse of this function to the same file to have both implementations in the same place.

Related Issues

Related to #21995

@martijnjanssen martijnjanssen requested a review from a team as a code owner March 11, 2020 19:51
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for new PR! ;)

@pieh pieh merged commit 306cadd into gatsbyjs:master Mar 11, 2020
@martijnjanssen martijnjanssen deleted the chore/typescript branch March 11, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants