Blog add author greg thomas #22693
Closed
Blog add author greg thomas #22693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we make this part of the blog PR itself? |
|
I tried that first. But it seems like the build was feeling because Greg didn’t yet exist as an author. logically it seemed that it made sense to do a separate branch, add avatar and yaml , commit, PR. then push the branch with the blog post itself that would be calling upon these assets.
Sent from my iAnsible.
… On Mar 31, 2020, at 2:07 PM, LB ***@***.***> wrote:
Can we make this part of the blog PR itself?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
It looked like the other PR got closed? |
|
I closed the original PR because it kept failing |
|
This one is live, though. The avatar is failing for some reason. I ran the linter. |
|
Duplicate of #22671 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(blog) setting up new author in the db