Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): improve async commons chunking #22879

Merged
merged 1 commit into from
Apr 9, 2020
Merged

fix(gatsby): improve async commons chunking #22879

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/gatsby/src/utils/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,10 +530,13 @@ module.exports = async (
reuseExistingChunk: true,
},
commons: {
// only bundle non-async modules
chunks: `initial`,
name: `commons`,
// if a chunk is used on all components we put it in commons
minChunks: componentsCount,
// if a chunk is used on all components we put it in commons (we need at least 2 components)
minChunks: Math.max(componentsCount, 2),
priority: 20,
reuseExistingChunk: true,
},
// If a chunk is used in at least 2 components we create a separate chunk
shared: {
Expand Down