Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (scripts/i18n) Add label to the sync PR even if no conflicts #23014

Merged
merged 1 commit into from
Apr 10, 2020
Merged

fix (scripts/i18n) Add label to the sync PR even if no conflicts #23014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions scripts/i18n/sync.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,7 @@ async function syncTranslationRepo(code) {
body: syncPRBody(),
maintainerCanModify: true,
})
await addLabelToPullRequest(syncPR, syncLabel)

// if we successfully publish the PR, pull again and create a new PR --
shell.exec(`git checkout master`)
Expand Down Expand Up @@ -332,9 +333,6 @@ async function syncTranslationRepo(code) {
maintainerCanModify: true,
draft: true,
})

logger.info(`Adding ${syncLabelName} labels to created pull requests...`)
await addLabelToPullRequest(syncPR, syncLabel)
await addLabelToPullRequest(conflictsPR, syncLabel)
}

Expand Down