Add mutations to Recipes GraphQL server #23335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LekoArts
reviewed
Apr 21, 2020
|
Would it be sensible to update the current test for this file or add more tests? The current test seems a bit sparse. |
KyleAMathews
approved these changes
Apr 21, 2020
| @@ -2,6 +2,7 @@ const Joi2GQL = require(`./joi-to-graphql`) | |||
| const Joi = require(`@hapi/joi`) | |||
| const { GraphQLString, GraphQLObjectType, GraphQLList } = require(`graphql`) | |||
| const _ = require(`lodash`) | |||
| const { ObjectTypeComposer, schemaComposer } = require(`graphql-compose`) | |||
There was a problem hiding this comment.
this is a convenient helper function!
There was a problem hiding this comment.
Super nice! Glad I stumbled upon it, shoutout to @freiksenet who pointed it out in some really old graphql.js issue 🔥
mxstbr
force-pushed
the
feat/recipes-graphql-mutations
branch
from
6ff3d43 to
9a6be09
Compare
|
Merged into #23291 manually to avoid the squash and merge! |
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds resource mutations to the Recipes GraphQL server. For every resource, we generate
createX(x: XInput),updateX(x: XInput)anddestroyX(x: XInput)mutations. This is what that looks like right now: