docs: new source plugin tutorial #23363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and subscriptions
gillkyle
added
the
type: documentation
LekoArts
reviewed
Apr 23, 2020
laurieontech
previously requested changes
Apr 23, 2020
There was a problem hiding this comment.
What a lift Kyle! Great work. Left some recommendations.
My general opinion is that this is such a big improvement we should get it in soon and deal with any small tweaks down the road. That being said, I'd like to take a detailed look at the headings to make sure people can jump to sections if they want examples given the length of the tutorial. Would also be good to triple check we're not mixing any other pixabay references.
Co-Authored-By: Kyle Gill <kylerobertgill@gmail.com>
Co-Authored-By: LB <laurie@gatsbyjs.com> Co-Authored-By: Lennart <lekoarts@gmail.com>
Co-Authored-By: LB <laurie@gatsbyjs.com>
Co-Authored-By: LB <laurie@gatsbyjs.com>
…sby into docs/source-plugin-tutorial
gillkyle
added
the
status: awaiting reviewer response
AishaBlake
suggested changes
May 5, 2020
AishaBlake
removed
the
status: awaiting reviewer response
gillkyle
commented
May 6, 2020
gillkyle
commented
May 6, 2020
Co-authored-by: Aisha Blake <aisha@gatsbyjs.com>
AishaBlake
approved these changes
May 6, 2020
2 tasks
|
PS: i deleted my comments and will open a new issue when i completed the tutorial myself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the final step of the long worked on plugin authoring workflow.
This (rather big) tutorial was an effort to improve the materials supporting more advanced use cases for plugins. It's an extension of the new source plugin guide that uses a more sophisticated example for reference. That example is rebuilt in the tutorial to teach:
Retiring the Pixabay tutorial:
The Pixabay tutorial provides some good context, but doesn't explain some of those key features. I propose removing it in favor of this new tutorial, many of the sections were taken from the old guide and modified. I think this new tutorial will cover more commonly implemented features and set users up for integration with Gatsby Cloud (which was one of its goals).
View partial screenshot
Related Issues
Fixes #16095