chore(gatsby): migrate schema reducer to TypeScript #23476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements the migration of the schema reducer to TypeScript by adding the SET_SCHEMA action to the ActionsUnion and by adding the basic types from the IGatsbyState.
|
Hey @hiwelo 👋 |
|
🤦 I think I deleted the fork entirely when I wanted to delete another branch 🤦 |
|
Hmm, in fact I will open a new PR with the new branch. Sorry for that |
| import { ActionsUnion, IGatsbyState } from "../types" | ||
|
|
||
| export const schemaReducer = ( | ||
| state: IGatsbyState["schema"] | {} = {}, |
There was a problem hiding this comment.
This isn't quite what I was getting at. I think it would better if we could default this state to an instance of graphql schema. There are APIs and keys that are expected to be on this state. It's fragile to not have them there, even though we must be supporting that as is right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit implements the migration of the schema reducer to TypeScript by adding the
SET_SCHEMAaction to theActionsUnionand by adding the basic types from theIGatsbyStateinterface.Related Issues
Related to #21995