Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix to recipes discoverability #23767

Merged
merged 7 commits into from
May 9, 2020
Merged

Conversation

shannonbux
Copy link
Contributor

Problem

@laurieontech pointed out (and I can provide evidence from watching people's screen recordings of using recipes!) that it is difficult to find the list of recipes or instructions on how to use them.

Solution

The top google hits for "gatsby recipes" are now #1 the blogpost (which works well for helping people discover the right information) and #2 www.gatsbyjs.org/docs/recipes/ which does not work well for helping people discover the new form of recipes.

This PR is a quick fix and maybe could use some improvements:

  • Should we list the official recipes out? I could do it, just not sure we want to maintain it...
  • I'm not sure how to link to the community recipes individually. Where is that list? Or we could just share this in the umbrella issue and tweet it and ask people to PR in their own link!

Should we list the official recipes out?

I'm not sure how to link to the community recipes individually. Where is that list? Or we could just share this in the umbrella issue and tweet it and ask people to PR in their own link.
@shannonbux shannonbux requested a review from a team as a code owner May 4, 2020 22:43
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 4, 2020
`gatsby recipes https://example.com/recipe-url.mdx`
```

Note: GitHub doesn't yet support viewing MDX files. In order to view a recipe in the GitHub UI you'll want to click into the recipe file and click on the "Raw" button.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Note: GitHub doesn't yet support viewing MDX files. In order to view a recipe in the GitHub UI you'll want to click into the recipe file and click on the "Raw" button.
Note: GitHub doesn't yet support viewing MDX files. In order to view a recipe in the GitHub UI you'll want to click into the recipe file and click on the "Raw" button.

This is failing lint on a missing newline at the end of the file!

@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 5, 2020
@@ -29,6 +29,12 @@ A live example may not be possible depending on the nature of the recipe, in whi
See [docs templates](/docs/docs-templates/) in the contributing docs for more help.
-->

## New automated recipes available!

Some recipes are now available in a more automated form - you can run some steps of the recipes through the CLI! [See a list of these automated recipes here](/docs/automated-recipes.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking something like this? Probably needs some wordsmithing, but since we don't have full coverage on the recipes listed here I'm not sure we're ready to conflate the two.

You may have found this page when searching for the new automated Gatsby recipes! Note that these are still experimental and thus can be found in the Gatsby GitHub repo recipes package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nice I like that!

@laurieontech
Copy link
Contributor

The recipes list makes a lot of sense but it starts pulling in a lot of docs review/repo awareness perhaps prematurely. Alternatively, the list could live in markdown at the root of the recipes package directory?

@shannonbux
Copy link
Contributor Author

@laurieontech I think that could be an effective alternative! The deciding factors imo are:

  • what will be easy to pull into Admin?
  • what will recipes creators enjoy / find easy to contribute to and maintain?

Afaik, wouldn't the maintenance for a doc vs a markdown file in the recipes repo be similar? Correct me if I'm wrong!

Finally, if this does go in docs, I need a reminder of where the docs sidebar file is. I remember it being yml

@laurieontech
Copy link
Contributor

The overhead is roughly the same but the review cycle for something that lives in docs vs the recipes package is different.

If we do end up adding the listing to the docs we should think on the sidebar discoverability. With the duplicate recipes name I think we’re better off with a direct link rather than a new section. Especk ally because ideally they’re the same section of the docs in the long term.

@acao
Copy link
Contributor

acao commented May 7, 2020

technical idea for generating the list: gatsby official and community recipies should have an npm package tag like recipe or gatsby-recipe, and then we can just build a simple source plugin to generate a list of recipe packages for this page from npm itself. @KyleAMathews is that what you had in mind?

@AishaBlake
Copy link

100% agree with Laurie's assessment. For right now, while automated recipes are still an experiment, I think we should keep this information in the gatsby-recipes package. Long-term, I'd like to avoid maintaining a full list of recipes in the docs. I feel like it'll get out of hand really quickly.

ok @laurieontech and @AishaBlake I think this will be the simplest quick fix to solve SEO issue
@shannonbux
Copy link
Contributor Author

Thanks to @shrthnd for an idea that inspired the last commit, too! #23320 (comment)

@shannonbux shannonbux mentioned this pull request May 8, 2020
15 tasks
Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is a good place to start! Thanks, @shannonbux!

@shannonbux
Copy link
Contributor Author

Thanks for fixing the blog link @AishaBlake!

@AishaBlake AishaBlake merged commit 51fabdb into master May 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the improve-recipe-discoverability branch May 9, 2020 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants