Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(www): update jsdoc source for actions after typescript migration #23779

Merged
merged 1 commit into from
May 5, 2020
Merged

fix(www): update jsdoc source for actions after typescript migration #23779

merged 1 commit into from
May 5, 2020

Conversation

pieh
Copy link
Contributor

@pieh pieh commented May 5, 2020 •
edited
Loading

Description

#22297 migrated actions/restricted.js to actions/restricted.ts but our API docs were not updated to use new extension

Related Issues

fixes #23668

@pieh pieh requested a review from a team as a code owner May 5, 2020 08:40
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 5, 2020
@pieh pieh added type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 5, 2020
@pieh
Copy link
Contributor Author

pieh commented May 5, 2020

This fixes the missing createTypes (among other) actions in docs - https://build-006d12bc-19e7-4d17-8d08-0bfef95dd7db.gtsb.io/docs/actions/#createTypes

sidharthachatterjee
sidharthachatterjee approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@sidharthachatterjee sidharthachatterjee merged commit 907d9ef into master May 5, 2020
@sidharthachatterjee sidharthachatterjee deleted the docs-restricted-actions-ts branch May 5, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

Assignees
No one assigned
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing spec createTypes on Gatsby API > Actions page
2 participants
@pieh @sidharthachatterjee