Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(source-wikipedia): ugrade dependencies #23810

Merged
merged 1 commit into from
May 6, 2020

Conversation

Slashgear
Copy link
Contributor

Description

  • remove @babel/runtime useless dependency
  • add missing bluebird dependency (used in package but not listed)
  • remove usage of axios to use node-fetch which seems to be most used fetch lib in packages
    • 💡We may need to harmonize usage of fetching libs
  • querystring is sadly not maintained now and query-string is used in many packages
    • 💡We may need to harmonize queryString libs in the monorepo
    • add it to dependencies

💡I could add some test with jest in a dedicated PR
💡I could add option to load wikipedia depending on local

Documentation

Related Issues

@Slashgear Slashgear requested a review from a team as a code owner May 5, 2020 21:52
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 5, 2020
@danabrit danabrit added status: inkteam assigned and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 5, 2020
@wardpeet
Copy link
Contributor

wardpeet commented May 6, 2020

Hey, thanks for opening this pull request. Changes look good! We're always happy to receive tests for our plugins.

remove usage of axios to use node-fetch which seems to be most used fetch lib in packages
💡We may need to harmonize usage of fetching libs

We don't have an opinion on fetching libraries if any we would switch to got as it has retry mechanisms built-in.

@wardpeet wardpeet merged commit 9275666 into gatsbyjs:master May 6, 2020
@wardpeet
Copy link
Contributor

wardpeet commented May 6, 2020

Published in gatsby-source-wikipedia@2.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants