Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(www): Change from react-loadable to loadable-components #23830

Merged
merged 1 commit into from
May 6, 2020
Merged

chore(www): Change from react-loadable to loadable-components #23830

merged 1 commit into from
May 6, 2020

Conversation

Thihup
Copy link
Contributor

@Thihup Thihup commented May 6, 2020

Description

Changed from React Loadable to Loadable Components in Debugging HTML Builds doc page

@Thihup Thihup requested a review from a team as a code owner May 6, 2020 12:47
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 6, 2020
@wardpeet wardpeet changed the title Change from react-loadable to loadable-components chore(www): Change from react-loadable to loadable-components May 6, 2020
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks yeah loadable-components is preferred to use!

@wardpeet wardpeet merged commit 649b4dd into gatsbyjs:master May 6, 2020
@gatsbot
Copy link

gatsbot bot commented May 6, 2020

Holy buckets, @Thihup — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@Thihup Thihup deleted the patch-1 branch May 6, 2020 17:10
@vladar vladar removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants