fix(www): Allow API docs to reference top level TS exports #23863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
ascorbic
added
topic: website
and removed
status: triage needed
This was referenced May 7, 2020
gillkyle
approved these changes
May 7, 2020
There was a problem hiding this comment.
Sounds like it makes sense to me! Checking the build verifies that the APIs are showing up okay and since a couple of those pages are broken on the docs now I think this should get merged in sooner rather than later 🙂
Thanks for the help @ascorbic 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently API docs filter out definitions that do not include a
memberoffield. This is not set in top level exports in TypeScript files, so was causing the Node API docs to go missing.This PR just removes that filter. I don't think this should include any unexpected definitions.
Related Issues
Fixes #23857