Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-cli): don't fail when using --log-pages and/or --write-to-file #23951

Merged
merged 3 commits into from
May 11, 2020
Merged

fix(gatsby-cli): don't fail when using --log-pages and/or --write-to-file #23951

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92b66f4
Adding new cli options for page optimization
albertlincoln May 9, 2020
36be9ab
prettier
albertlincoln May 9, 2020
2d870e8
make them hidden, add some description as well as comment about why t…
pieh May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/gatsby-cli/src/create-cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,20 @@ function buildLocalCommands(cli, isLocalSite) {
.option(`open-tracing-config-file`, {
type: `string`,
describe: `Tracer configuration file (OpenTracing compatible). See https://gatsby.dev/tracing`,
})
// log-pages and write-to-file are specific to experimental GATSBY_EXPERIMENTAL_PAGE_BUILD_ON_DATA_CHANGES feature
// because of that they are hidden from `--help` but still defined so `yargs` know about them
.option(`log-pages`, {
type: `boolean`,
default: false,
describe: `Log the pages that changes since last build (only available when using GATSBY_EXPERIMENTAL_PAGE_BUILD_ON_DATA_CHANGES).`,
hidden: true,
})
.option(`write-to-file`, {
type: `boolean`,
default: false,
describe: `Save the log of changed pages for future comparison (only available when using GATSBY_EXPERIMENTAL_PAGE_BUILD_ON_DATA_CHANGES).`,
hidden: true,
}),
handler: handlerP(
getCommandHandler(`build`, (args, cmd) => {
Expand Down