chore(gatsby): Migrate utils/page-data to TypeScript #23991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
hiwelo
added
type: TypeScript migration
and removed
status: triage needed
|
@blainekasten I had to open a new PR because of the deletion of the fork few days ago 🙄 Sorry for that. |
hiwelo
force-pushed
the
ts-migration/utils-page-data
branch
from
07dccdd to
b2696ca
Compare
This commit migrates the existing `src/utils/page-data.ts` file to TypeScript by trying to stick as close as possible to the original JavaScript file. To take advantage of existing Redux typings, I tried to extend the typings from the `IGatsbyPage` interface describing page data.
hiwelo
force-pushed
the
ts-migration/utils-page-data
branch
from
b2696ca to
cdde8c8
Compare
hiwelo
added
the
status: needs core review
blainekasten
approved these changes
Jun 16, 2020
axe312ger
pushed a commit
that referenced
this pull request
Jun 23, 2020
* chore(gatsby): Migrate utils/page-data to TypeScript This commit migrates the existing `src/utils/page-data.ts` file to TypeScript by trying to stick as close as possible to the original JavaScript file. To take advantage of existing Redux typings, I tried to extend the typings from the `IGatsbyPage` interface describing page data. * Improve function naming * convert to functions * update yarn.lock * skip typechecking gatsby-admin Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit migrates the existing
src/utils/page-data.tsfile to TypeScript by trying to stick as close as possible to the original JavaScript file.To take advantage of existing Redux typings, I tried to extend the typings from the
IGatsbyPageinterface describing page data.Related Issues
Related to #21995