Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): Convert page-data-stats reducer to TypeScript #24082

Merged
merged 3 commits into from
May 19, 2020

Conversation

carrotderek
Copy link
Contributor

Description

This PR converts packages\gatsby\src\redux\reducers\page-data-stats.js to TypeScript and updates related files.

Related Issues

Related to #21995

@carrotderek carrotderek requested a review from a team as a code owner May 14, 2020 02:54
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 14, 2020
@iamdarshshah iamdarshshah added type: TypeScript migration and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 14, 2020
@pieh pieh self-assigned this May 18, 2020
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

And thanks for resolving conflicts that I saw yesterday (was planning to not bother you with that and do it myself but you beat me to it! :D)

@pieh pieh merged commit bdf0247 into gatsbyjs:master May 19, 2020
@gatsbot
Copy link

gatsbot bot commented May 19, 2020

Holy buckets, @carrotderek — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

pieh pushed a commit to taejs/gatsby that referenced this pull request May 19, 2020
@carrotderek carrotderek deleted the page-data-stats-reducer-to-ts branch May 19, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants