Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ts migration/convert yurnalist logger #24224

Merged
merged 9 commits into from
May 20, 2020

Conversation

blainekasten
Copy link
Contributor

Description

Converts the last logger.
Also fixes up a few things from previous merges

Related Issues

Related to #21995

@blainekasten blainekasten requested a review from a team as a code owner May 19, 2020 14:47
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 19, 2020
pvdz
pvdz previously approved these changes May 19, 2020
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dangit github, at least let me tell you to compare two files rather than just considering a rename a delete and new instead :(

Anyways, nice

@pvdz pvdz added type: TypeScript migration and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 19, 2020
@blainekasten blainekasten added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label May 20, 2020
@gatsbybot gatsbybot merged commit 342d835 into master May 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the ts-migration/convert-yurnalist-logger branch May 20, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants