Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(glossary): IaC - fix name for consistency #24503

Merged
merged 1 commit into from
Jun 2, 2020
Merged

fix(glossary): IaC - fix name for consistency #24503

merged 1 commit into from
Jun 2, 2020

Conversation

muescha
Copy link
Contributor

@muescha muescha commented May 26, 2020

Description

changes for consistency with Glossary Page ( https://www.gatsbyjs.org/docs/glossary/infrastructure-as-code/ )

  • Infrastructure As Code -> Infrastructure as Code

Motivation

-### [Infrastructure As Code](/docs/glossary/infrastructure-as-code/)
+### [Infrastructure as Code](/docs/glossary/infrastructure-as-code/)

I think we can refer to this as Infrastructure as Code or IaC throughout. As long as "as" isn't capitalized and we're consistent all the way through, I'm good.

Originally posted by @AishaBlake in https://github.com/gatsbyjs/gatsby/pull/23431/files

Related Issues

@muescha muescha requested a review from a team as a code owner May 26, 2020 18:15
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 26, 2020
@Ekwuno Ekwuno added type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 27, 2020
mendaomn
mendaomn approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@mendaomn mendaomn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does seem to follow the casing style guide if you consider those to be subheadings 👍

@muescha
Copy link
Contributor Author

muescha commented May 27, 2020

but i think that "brand names" or "technology" names are overwrite the casing style of subheadings

marcysutton
marcysutton approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, thanks for the PR!

@marcysutton marcysutton merged commit 2e020f4 into gatsbyjs:master Jun 2, 2020
@muescha muescha deleted the muescha/fix/glossary-iac-fix branch June 2, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mendaomn mendaomn mendaomn approved these changes

@marcysutton marcysutton marcysutton approved these changes

Assignees
No one assigned
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@muescha @marcysutton @mendaomn @Ekwuno