Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deploy to Gatsby Cloud subsection to main tutorial #24576

Merged
merged 6 commits into from
Jun 10, 2020

Conversation

katmh
Copy link
Contributor

@katmh katmh commented May 28, 2020

Description

I added a subsection to Tutorial Part 1 about how to deploy to Gatsby Cloud. I included brief descriptions of what Gatsby Cloud is, how to push the local repo to Github, and linked to the reference guide on Deploying to Gatsby Cloud.

I presented this in the tutorial as an alternative to Surge, but kept the Surge instructions in there since that process is more streamlined. However, I do think it makes sense to introduce Github and Gatsby Cloud to beginner developers early in their journey with Gatsby.

Related Issues

Fixes #24574

@katmh katmh requested a review from a team as a code owner May 28, 2020 16:47
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 28, 2020
docs/tutorial/part-one/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-one/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-one/index.md Show resolved Hide resolved
@mgienow mgienow added status: needs docs review Pull request related to documentation waiting for review and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 28, 2020
Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for diving in so quickly, Kat! In addition to my specific comments, could you also do a quick sweep to make sure GitHub is capitalized correctly throughout?

docs/tutorial/part-one/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-one/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-one/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-one/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-one/index.md Outdated Show resolved Hide resolved
Kat Huang and others added 2 commits May 29, 2020 11:19
Github → GitHub, add 'shell' to code blocks, relative URLs, make Gatsby Cloud H3 level
Co-authored-by: Aisha Blake <aisha.g.blake@gmail.com>
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I assume all the quote changes are from Prettier?

@marcysutton marcysutton merged commit e908448 into gatsbyjs:master Jun 10, 2020
@gatsbot
Copy link

gatsbot bot commented Jun 10, 2020

Holy buckets, @katmh — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

axe312ger pushed a commit that referenced this pull request Jun 23, 2020
* Add Gatsby Cloud subsection

* 'Gatsby.js' → 'Gatsby'

* Add more benefits of Gatsby Cloud

* Use straight quotes instead of curly

* Address requested changes

Github → GitHub, add 'shell' to code blocks, relative URLs, make Gatsby Cloud H3 level

* Make Gatsby Cloud H3 level

Co-authored-by: Aisha Blake <aisha.g.blake@gmail.com>

Co-authored-by: Aisha Blake <aisha.g.blake@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs docs review Pull request related to documentation waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reference Gatsby Cloud as deployment option in introductory tutorial
4 participants