Strip ACF key from response when not an object

[crgeary]

Fixes: #2471

This PR removes acf: false from the WP API response.

When a post doesn't have any ACF fields, the WP API is set to acf: false which breaks all posts in that post type. Instead, we should just remove acf: false as it's not required.

[KyleAMathews]

Deploy preview failed.

Built with commit 4e771a4

https://app.netlify.com/sites/using-glamor/deploys/59e4fc970b79b77f22960842

[gatsbybot]

Deploy preview ready!

Built with commit 2066b65

https://deploy-preview-2473--gatsbygram.netlify.com

[KyleAMathews]

Looking great! Thanks for finding the root cause of the trouble + putting together the PR.

Could you also add a simple test as well — e.g. make up a fake entity array [{id: 1, acf: false}] and test that acf is gone.

[KyleAMathews]

No need to iterate over keys

[KyleAMathews]

👍

Will wait for tests to pass then merge/release. Thanks!

[crgeary]

Awesome! Sorry it took a while. Thanks for the tips!

[jlengstorf]

Hiya @crgeary! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜