Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - Lighthouse audits #24779

Closed
wants to merge 7 commits into from
Closed

Docs - Lighthouse audits #24779

wants to merge 7 commits into from

Conversation

shanejones
Copy link
Contributor

@shanejones shanejones commented Jun 4, 2020

Giving the page a bit of an update and using up to date screenshots.

@shanejones shanejones requested a review from a team as a code owner June 4, 2020 14:12
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 4, 2020
@ascorbic
Copy link
Contributor

ascorbic commented Jun 4, 2020

Hi. Thanks for the contribution. Can you separate out the parts which add the site to the showcase from the part that adds the docs please?

@ascorbic ascorbic added status: needs docs review Pull request related to documentation waiting for review and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 4, 2020
@shanejones
Copy link
Contributor Author

Hi @ascorbic

What's the best way to do that? I thought the 2 PR's being separate would have done that for me.

@ascorbic
Copy link
Contributor

ascorbic commented Jun 4, 2020

Hi. You'll need to create a separate branch for each PR, based on master

@shanejones
Copy link
Contributor Author

Got it, will kill this PR for now

@shanejones shanejones closed this Jun 4, 2020
@shanejones shanejones changed the title Lighthouse audit documentation Docs - Lighthouse audits Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs docs review Pull request related to documentation waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants