Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs - Lighthouse audits #24783

Merged
merged 4 commits into from
Jun 10, 2020
Merged

Docs - Lighthouse audits #24783

merged 4 commits into from
Jun 10, 2020

Conversation

shanejones
Copy link
Contributor

Giving the page a bit of an update and using up to date screenshots.

This PR closes #24778

@shanejones shanejones requested a review from a team as a code owner June 4, 2020 17:00
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 4, 2020
@freiksenet freiksenet added status: needs docs review Pull request related to documentation waiting for review type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 5, 2020
marcysutton
marcysutton previously approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the PR!

@marcysutton marcysutton merged commit 7f38822 into gatsbyjs:master Jun 10, 2020
@gatsbot
Copy link

gatsbot bot commented Jun 10, 2020

Holy buckets, @shanejones — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

axe312ger pushed a commit that referenced this pull request Jun 23, 2020
@shanejones @axe312ger
Docs - Lighthouse audits (#24783)
74ecc0c 
* updating content and screenshots

* Fix linting

Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcysutton marcysutton marcysutton approved these changes

Assignees
No one assigned
Labels
status: needs docs review Pull request related to documentation waiting for review type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lighthouse Audit Documentation outdated
3 participants
@shanejones @marcysutton @freiksenet