Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(blog): gazette may - remove local domain, brand names, typos #24824

Merged
merged 1 commit into from
Jun 10, 2020
Merged

fix(blog): gazette may - remove local domain, brand names, typos #24824

merged 1 commit into from
Jun 10, 2020

Conversation

muescha
Copy link
Contributor

@muescha muescha commented Jun 5, 2020

Description

changes:

  • remove domain from local links
  • fix brand names:
    • Javascript -> JavaScript
    • Typescript -> TypeScript
    • TypeScrip -> TypeScript
    • AgilityCMS -> Agility CMS
    • opentracing -> OpenTracing
    • virtual Gatsby Days -> Virtual Gatsby Days
  • use relative path for images
  • space before link
  • replace here links with better description for a11y

Related Issues

@muescha muescha requested a review from a team as a code owner June 5, 2020 19:44
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 5, 2020
@danabrit danabrit added topic: blogpost and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 8, 2020
marcysutton
marcysutton approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@marcysutton marcysutton merged commit 3858990 into gatsbyjs:master Jun 10, 2020
@muescha muescha deleted the muescha/fix/gazette-may-fix branch June 11, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcysutton marcysutton marcysutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muescha @marcysutton @danabrit