chore(gatsby): migrate run-sift to TS #25055
Conversation
gatsbot
bot
added
the
status: triage needed
pvdz
added
topic: TypeScript migration
and removed
status: triage needed
| @@ -50,7 +50,7 @@ export function createDbQueriesFromObject(filter: object): Array<DbQuery> { | |||
| } | |||
|
|
|||
| function createDbQueriesFromObjectNested( | |||
| filter: object, | |||
| filter: Record<string, any>, | |||
There was a problem hiding this comment.
Can this be Record<string, unknown>
There was a problem hiding this comment.
Changing the any to unknown triggers cascading errors. Are you sure that's the right way?
There was a problem hiding this comment.
May be related to this:
packages/gatsby/src/db/common/query.ts:63:57 - error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'Record<string, unknown>'.
I hate that my editor throws different errors from yarn typecheck from whatever yarn format does. There should be one state :/
|
Typing fixed, tests are still broken. |
This change is broken because references are not updated. Separate commit for your reviewing pleasure. (The PR will squash it and github will still screw up the rename but at least review is good.)
While trying to be type correct, coercing the value to string has the unintended side effect of allowing regexes (or any other type) as $regex arg. So instead now throwing an explciit error for that case. Also reverted the type where it returns an Array. Apparently there are cases where it is not an array.
|
Ok. Tests should pass now. Typings were cleaned up. I thought runFastFilters would accept an array of filters to apply. But apparently, and through the magic of lodash, that's not exactly the case. So I reverted annotating those input/output types as arrays. Also removed a String case that was accidentally allowing types that shouldn't be allowed. Good thing we have tests :) |
pvdz
added
the
status: needs core review
* Rename file to .ts and drop the sift name This change is broken because references are not updated. Separate commit for your reviewing pleasure. (The PR will squash it and github will still screw up the rename but at least review is good.) * Convert run-fast-filters (run-sift) to TS * Applied suggestions * Remove more unknowns * wip * Fix regression While trying to be type correct, coercing the value to string has the unintended side effect of allowing regexes (or any other type) as $regex arg. So instead now throwing an explciit error for that case. Also reverted the type where it returns an Array. Apparently there are cases where it is not an array.
Converts run-sift to TS and removes "sift" from the file name.