chore(www): convert ImagePlaceholder used in guidelines to theme-ui #25078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
…e/image-placeholder
tesseralis
previously approved these changes
Jun 17, 2020
|
@tesseralis |
abhishekjakhar
added
topic: website
and removed
status: triage needed
tesseralis
reviewed
Jun 19, 2020
Comment on lines
2
to
3
| import { jsx } from "theme-ui" | ||
| import { Box } from "theme-ui" |
There was a problem hiding this comment.
Can we combine these together or does it break the JSX pragma?
Suggested change
| import { jsx } from "theme-ui" | |
| import { Box } from "theme-ui" | |
| import { jsx, Box } from "theme-ui" |
tesseralis
previously approved these changes
Jun 19, 2020
Yes, I combined them, please check now |
|
@tesseralis can I get a review on this and my other PR’s? |
tesseralis
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Convert the
<ImagePlaceholder/>component to theme-uiScreenshot(s)
How to test
The ImagePlaceholder is being used only on typography page, it is used at 3 places, the images are provided above
The images provided above should look same on both local and production URL mentioned below
Local URL: http://localhost:8000/guidelines/typography/
Production URL: https://www.gatsbyjs.org/guidelines/typography/