fix(gatsby-transformer-documentationjs): Add childOf, mimeTypes and fill in other schema typings #25113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
tesseralis
commented
Jun 19, 2020
| @@ -45,7 +45,7 @@ function prepareDescriptionNode(node, markdownStr, name, helpers) { | |||
| exports.sourceNodes = ({ actions }) => { | |||
| const { createTypes } = actions | |||
| const typeDefs = /* GraphQL */ ` | |||
| type DocumentationJs implements Node { | |||
| type DocumentationJs implements Node @childOf(types: ["File", "DocumentationJs"]) { | |||
There was a problem hiding this comment.
Would anything break if we specify that the file is a child of itself? (each DocumentationJs node has child nodes)
Also should we add a mimeTypes: ["application/javascript"] here too?
There was a problem hiding this comment.
I've run a quick test and specifying childOf of self doesn't seem to break anything. As for mimeTypes - this should also work but I don't have enough context on this plugin to say if it makes sense here.
smthomas
added
topic: transformers
and removed
status: triage needed
delete-merged-branch
bot
deleted the
gatsby-transformer-documentationjs/schema-improvements
branch
This was referenced Jun 29, 2020
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
…ill in other schema typings (gatsbyjs#25113) * Add mimeTypes and other directives to fill in files * add placeholder type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@childOfdirective toDocumentationJstype to verify it's a descendant of File nodes.type DocumentationJSComponentDescriptionand add a@mimeTypesto specify it's a Markdown node.Related
#25112