Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(www): Tidy sx prop space usage #25333

Merged
merged 14 commits into from
Jun 27, 2020
Merged

chore(www): Tidy sx prop space usage #25333

merged 14 commits into from
Jun 27, 2020

Conversation

fk
Copy link
Contributor

@fk fk commented Jun 26, 2020

fk added 14 commits June 26, 2020 01:27
@fk
chore(www): Tidy space, color, fix :hover
e4d3edd
@fk
chore(www): Tidy space token value usage
883c97e
@fk
chore(www): Tidy space token value usage
1638b6d
@fk
chore(www): Tidy space token value usage
8927d3b
@fk
chore(www): Tidy space token value usage
616125d
@fk
chore(www): Tidy space token value usage
6e579c1
@fk
chore(www): Tidy space token value usage
710403b
@fk
chore(www): Tidy space token value usage
1ee8ff6
@fk
chore(www): Tidy space token value usage
bcb3597
@fk
chore(www): Tidy space token value usage
43bf9f0
@fk
chore(www): Use sidebarItemMinHeight token
a9e1686
@fk
fix(www): TitleButton indention, padding-right
1e165de 
This is currently not in use so will leave it alone, but this thing's height and `hover`, `active` states are also off a little.
@fk
chore(www): Tidy space token value usage
0376662
@fk
chore(www): Tidy space token value usage
9963afc 
Not really in use either, but let's fix the "pull in page margin" thing.
@fk fk requested a review from gillkyle June 26, 2020 16:27
@fk fk requested a review from a team as a code owner June 26, 2020 16:27
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 26, 2020
@fk fk added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: website and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 26, 2020
gillkyle
gillkyle reviewed Jun 26, 2020
View reviewed changes
Copy link
Contributor

@gillkyle gillkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One set of spacing changed from the old to new. Maybe that was intentional. If so I'm cool to approve/merge! From my understanding, adding these sx theme aware properties makes these values codemod-able so we can add or remove from the spacing scale easier.

www/src/templates/template-creator-details.js Show resolved Hide resolved
gillkyle
gillkyle approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@gillkyle gillkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@gatsbybot gatsbybot merged commit 7b0de96 into master Jun 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the fk/tidy-sx-prop-space-usage branch June 27, 2020 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gillkyle gillkyle gillkyle approved these changes

@tesseralis tesseralis tesseralis approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fk @tesseralis @gillkyle @gatsbybot