refactor(www): Convert Pullquote to use theme-ui #25351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
tesseralis
commented
Jun 27, 2020
| } | ||
| const starPositionStyles = [ | ||
| { | ||
| yellow: { side: `left`, offset: `1.8rem` }, |
There was a problem hiding this comment.
@fk another thing we can do is switch these to percentage points.
So for this one, if offset: `50%` , it will always be 50% between the top and bottom regardless of how tall the pullquote is. What do you think?
There was a problem hiding this comment.
If you think it still works out visually, go for it!
fk
approved these changes
Jun 27, 2020
pvdz
removed
the
status: triage needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the
<Pullquote>component to use theme-ui instead of styled-component style. In addition, refactor the styling for the star positions to make it more clear what the styles are doing.Related
Follow-up of #25282