Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(docs) Switch node definition language to TS and update some text #25632

Merged
merged 1 commit into from
Jul 17, 2020

Conversation

tesseralis
Copy link
Contributor

Description

Switch the language of the node definition in node-interface.md to typescript, based on the actual definition in index.d.ts. I noticed that this was the only code block that used the flow language. Since we don't support flow any more and are switching to TS, I figure it would be good to update the docs to reflect that as well.

@tesseralis tesseralis requested a review from a team as a code owner July 9, 2020 06:44
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 9, 2020
@gatsby-cloud-staging
Copy link

Your pull request can be previewed in Gatsby Cloud: https://build-af93c5ea-a0ab-4af9-93d2-921f8412e141.staging-previews.gtsb.io

@tesseralis tesseralis added status: needs docs review Pull request related to documentation waiting for review type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement. and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jul 9, 2020
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@blainekasten blainekasten merged commit cb282f5 into master Jul 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the docs/node-interface-language branch July 17, 2020 13:52
@marcysutton
Copy link
Contributor

Thanks, @blainekasten!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs docs review Pull request related to documentation waiting for review type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants