fix(gatsby-react-router-scroll): Properly scroll to 0 for new pages #25749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
blainekasten
removed
the
status: triage needed
|
Your pull request can be previewed in Gatsby Cloud: https://build-8628de84-c5dc-44d5-af51-caad8747964f.staging-previews.gtsb.io |
sidharthachatterjee
approved these changes
Jul 14, 2020
sidharthachatterjee
added
the
bot: merge on green
|
Thanks for fixing this. I've just upgraded gatsby and run into what I think is issue #25522 so very much waiting for this fix. I can't find any information about Gatsby release cycles/how long it takes to get a new version onto npm after a merge - please can anyone advise when this will be available? |
|
Ignore my previous comment: just seen 2.24.3 was published a couple of minutes ago https://github.com/gatsbyjs/gatsby/releases/tag/gatsby%402.24.3. Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #25745 and #25522.
The problem is that on page load, the location key is a constant of
initial. So when you navigate between two pages that uses full page reloads - the key is going to beinitialbetween each page which then matches in the state and reuses the value.The solution is to add the
pathnameto the key. So the key that we store in localStorage for a scroll position for a page should always include pathname and key if it's provided.Related Issues
Fixes #25745
Fixes #25522