Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][guides] other css frameworks #26087

Merged
merged 14 commits into from
Jul 30, 2020

Conversation

meganesu
Copy link
Contributor

Description

Adds a new Reference Guide to the CSS Libraries and Frameworks section for Other CSS Frameworks.

Related Issues

Closes #21541

@meganesu meganesu requested review from a team as code owners July 29, 2020 04:13
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 29, 2020
@meganesu meganesu changed the title Docs/other css frameworks [docs]: other css frameworks Jul 29, 2020
@meganesu meganesu changed the title [docs]: other css frameworks [docs][guides] other css frameworks Jul 29, 2020
@meganesu meganesu force-pushed the docs/other-css-frameworks branch from 58acc51 to 13eb4a1 Compare July 29, 2020 18:01
@AishaBlake AishaBlake self-assigned this Jul 29, 2020
@AishaBlake AishaBlake added topic: internal type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jul 29, 2020
Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, Megan! Thanks so, so much for working on this. I'm excited to add this guide to the Gatsby docs!

I've left a few comments and I'd love to hear your thoughts on my suggestions. In addition, there are a couple of places where I think it would be helpful to link to existing Gatsby documentation rather than (or potentially in addition to) linking out to more general library docs. Specifically, we have pages on Emotion and Styled Components which could complement this page well.

Once these have been addressed, I'll be glad to have another look. Thanks again for the time and attention you've put into this already.

@meganesu meganesu requested a review from AishaBlake July 30, 2020 00:06
@meganesu
Copy link
Contributor Author

@AishaBlake thanks for the feedback! I think I addressed everything. Let me know what you think!

AishaBlake
AishaBlake previously approved these changes Jul 30, 2020
Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! These changes look great. I left one suggestion which is truly a suggestion. One way or the other, I'm happy to merge this in!

Co-authored-by: Aisha Blake <aisha.g.blake@gmail.com>
@meganesu meganesu requested a review from AishaBlake July 30, 2020 20:07
@meganesu
Copy link
Contributor Author

(Oops, I accidentally dismissed your review, sorry 😬)

Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's okay. This is looking great! Thanks so much again for the contribution, Megan.

@AishaBlake AishaBlake merged commit 613589e into gatsbyjs:master Jul 30, 2020
@gatsbot
Copy link

gatsbot bot commented Jul 30, 2020

Holy buckets, @meganesu — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs][guides] Other CSS Frameworks and Libraries page
3 participants