-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][guides] other css frameworks #26087
[docs][guides] other css frameworks #26087
Conversation
58acc51
to
13eb4a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, Megan! Thanks so, so much for working on this. I'm excited to add this guide to the Gatsby docs!
I've left a few comments and I'd love to hear your thoughts on my suggestions. In addition, there are a couple of places where I think it would be helpful to link to existing Gatsby documentation rather than (or potentially in addition to) linking out to more general library docs. Specifically, we have pages on Emotion and Styled Components which could complement this page well.
Once these have been addressed, I'll be glad to have another look. Thanks again for the time and attention you've put into this already.
Co-authored-by: Aisha Blake <aisha.g.blake@gmail.com>
Co-authored-by: Aisha Blake <aisha.g.blake@gmail.com>
Co-authored-by: Aisha Blake <aisha.g.blake@gmail.com>
@AishaBlake thanks for the feedback! I think I addressed everything. Let me know what you think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! These changes look great. I left one suggestion which is truly a suggestion. One way or the other, I'm happy to merge this in!
Co-authored-by: Aisha Blake <aisha.g.blake@gmail.com>
(Oops, I accidentally dismissed your review, sorry 😬) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's okay. This is looking great! Thanks so much again for the contribution, Megan.
Holy buckets, @meganesu — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Description
Adds a new Reference Guide to the CSS Libraries and Frameworks section for Other CSS Frameworks.
Related Issues
Closes #21541