fix(gatsby-recipes): fix for when recipes have multiple NPMPackageJSON resources #26281
Conversation
gatsbot
bot
added
the
status: triage needed
KyleAMathews
added
topic: recipes
and removed
status: triage needed
Gatsby Cloud Build Reportusing-styled-components 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 21s PerformanceLighthouse report
|
Gatsby Cloud Build Reportgatsby-master 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 1m PerformanceLighthouse report
|
Gatsby Cloud Build Reportclient-only-paths 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 22s PerformanceLighthouse report
|
Gatsby Cloud Build Reportusing-reach-skip-nav 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 23s PerformanceLighthouse report
|
Gatsby Cloud Build Reportgatsby 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 5m PerformanceLighthouse report
|
Gatsby Cloud Build Reportgatsby 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 23m |
KyleAMathews
changed the title
| @@ -5,6 +5,63 @@ const getDiff = require(`../utils/get-diff`) | |||
|
|
|||
| const resourceSchema = require(`../resource-schema`) | |||
|
|
|||
| class Deferred { | |||
There was a problem hiding this comment.
This class is cool and seems useful. Is it or could it be used elsewhere?
There was a problem hiding this comment.
possibly! I copied it off stackoverflow haha — we'll probably migrate this whole bit of code that handles writing to a single shared resource (in this case to package.json) to its own library.
| @@ -173,8 +173,14 @@ const handleResource = (resourceName, context, props) => { | |||
| resolve(cachedValue) | |||
| updateResource(cachedValue) | |||
| } else { | |||
| // if (fn == `create`) { | |||
There was a problem hiding this comment.
Should we remove these comments and use debug directly? That way we can toggle them on and off.
There was a problem hiding this comment.
yeah... probably — not too worried about having really clean code still 🤷
…N resources (gatsbyjs#26281) * fix(gatsby-recipes): restrict changes to package.json to one at a time * Add message for npmpackagejson + make install output denser * update snapshots
Also threw in improvement to install output