Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relativeDirectory to destinationDir callback #27126

Closed
wants to merge 1 commit into from
Closed

Add relativeDirectory to destinationDir callback #27126

wants to merge 1 commit into from

Conversation

karlhorky
Copy link
Contributor

Description

Draft of a fix for #27097, to pass the linkNode.relativeDirectory to the destinationDir callback.

Documentation

If this is an ok solution, then I can add documentation!

Related Issues

Closes #27097

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 27, 2020
@LekoArts LekoArts added topic: remark/mdx Related to Markdown, remark & MDX ecosystem and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Sep 28, 2020
@LekoArts
Copy link
Contributor

Sorry for the late answer on this! I'd have rebased this onto master but the remote branch is deleted. If you're still up for it, could you open a new PR if this is still relevant to you? The change looks fine to me, only needs a unit test and some documentation.

Thanks!

@karlhorky
Copy link
Contributor Author

Open at #36213, thanks!

Not sure when I can get around to writing docs / unit tests, but if you have bandwidth to do this, would be super appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: remark/mdx Related to Markdown, remark & MDX ecosystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gatsby-remark-copy-linked-files: Add path property to file object in destinationDir function
2 participants