Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): switch from fast-levenshtein to fastest-levenshtein #27282

Merged
merged 2 commits into from
Oct 7, 2020
Merged

chore(deps): switch from fast-levenshtein to fastest-levenshtein #27282

merged 2 commits into from
Oct 7, 2020

Conversation

hoobdeebla
Copy link
Contributor

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 5, 2020
@LekoArts LekoArts added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 5, 2020
pvdz
pvdz reviewed Oct 5, 2020
View reviewed changes
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package is essentially now a proxy for fastest-levenshtein, while supporting an additional option that we don't use in gatsby-theme. Any chance you could update gatsby-theme to use fastest-levenshtein directly and reduce the stack? :)

@hoobdeebla
Copy link
Contributor Author

It looks like gatsby itself doesn't use that option either, so I switched both to use fastest-levenshtein. I also removed the DefinitelyTyped definitions as fastest-levenshtein ships its own type defs.

@hoobdeebla hoobdeebla changed the title chore(deps): update fast-levenshtein chore(deps): switch from fast-levenshtein to fastest-levenshtein Oct 5, 2020
@hoobdeebla hoobdeebla requested a review from pvdz October 7, 2020 03:27
pvdz
pvdz suggested changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's great.

I'm only missing package.json updates for adding the fastest-levenshtein packages, while removing the old package from them.

@hoobdeebla
Copy link
Contributor Author

I changed the package.json for both already - gatsby-theme, gatsby

@pvdz
Copy link
Contributor

pvdz commented Oct 7, 2020

Huh. Okay, can't argue with that. Not sure why I didn't see it before.

pvdz
pvdz approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 💜

@pvdz pvdz merged commit 354003f into gatsbyjs:master Oct 7, 2020
@hoobdeebla hoobdeebla deleted the updates/fast-levenshtein branch October 7, 2020 19:15
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
@gatsbybot
chore(deps): switch from fast-levenshtein to fastest-levenshtein (gat…
bf4dc0e 
…sbyjs#27282)

* chore(deps): update fast-levenshtein

* chore(deps): switch to fastest-levenshtein
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvdz pvdz pvdz approved these changes

Assignees
No one assigned
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hoobdeebla @pvdz @wardpeet @LekoArts