fix(blog-starter): don't pass data via context - pass identifiers #27359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: starters
and removed
status: triage needed
LekoArts
reviewed
Oct 9, 2020
vladar
reviewed
Oct 9, 2020
laurieontech
approved these changes
Oct 15, 2020
vladar
approved these changes
Oct 15, 2020
delete-merged-branch
bot
deleted the
fix/starter/blog/no-content-in-context
branch
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
…tsbyjs#27359) * fix(blog-starter): don't pass data via context - pass identifiers * don't use fragment * use nodes and not edges * drop console.log
This was referenced Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our starters we should use what we consider best practices for Gatsby. Passing data via context (instead of just identifiers) is causing quite a bit of problems. In our blog starter itself it actually isn't huge issue because we grab already available
titleandslug, but this approach of passing data like that is then copied over in user projects and build upon (getting excerpt, triggering image processing etc) and this is where this starts to get problematic.