perf(gatsby-source-contentful): dont linear search on a maybe large set #27447
+6
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvdz
added
topic: performance
gatsbot
bot
added
the
status: triage needed
pvdz
removed
the
status: triage needed
axe312ger
approved these changes
Oct 15, 2020
Contributor
axe312ger
left a comment
axe312ger
left a comment
There was a problem hiding this comment.
Sweet. Clean, readable and for sure faster. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before it was doing a
.includeson an array, searching for a particular sys.id. But that list could potentially have thousands of elements.By this changes it creates a single
Setof deleted ids, which has a much better lookup time, and can be used by both loops.