chore(gatsby-plugin-sass): add pluginOptionsSchema export #27466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
mfrachet
removed
the
status: triage needed
mfrachet
requested review from
ascorbic,
mxstbr,
laurieontech,
gillkyle and
a team
added 6 commits
October 16, 2020 15:17
mxstbr
approved these changes
Oct 16, 2020
There was a problem hiding this comment.
This looks fantastic to me! I looked through the plugin-sass and node-sass docs and can't find anything wrong with this schema. However, I agree that the documentation is a bit all over the place and it's hard to confirm the correctness of the schema with confidence 😅
| .description(`Override the file regex for SASS`), | ||
| useResolveUrlLoader: Joi.alternatives().try( | ||
| Joi.boolean(), | ||
| Joi.object({}).unknown(true) |
There was a problem hiding this comment.
We should type this better in the future, but it's not important enough for this v1 👍
There was a problem hiding this comment.
Yeah I totally agree with you :/ . I found this plugin very tough compared to some others 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add plugin schema options in
gatsby-plugin-sassRelates to #27242 and https://www.gatsbyjs.com/plugins/gatsby-plugin-sass/
Notes:
Joi.when()like the following:file or data must be specified(one or the other is strictly required)